Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds
.cjs
extension to commonjs bundle. Why do we need to save build ascjs
?If you try to require() an ES module (a package with
"type": "module"
in its package.json), Node.js will throw an error. This is because require() is a feature of CommonJS, not ES modules.We build package as ES Modules and as CommonJS. We have
"type": "module"
in the package.json, so if user wants to require package and use it is commonjs module they have an error.We can simply avoid it by adding
.cjs
extension to the module file. From nodejs documentation:Also this diff: